Skip to content

Add support for custom allocator for (C)String #79500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add support for custom allocator for (C)String #79500

wants to merge 3 commits into from

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Nov 28, 2020 •
edited
Loading

This follows the roadmap of the allocator WG to add custom allocators to collections.

currently blocked on:

r? @Amanieu

cc @rust-lang/wg-allocators
@rustbot modify labels: +A-allocators +T-libs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2020
@rustbot rustbot added A-allocators Area: Custom and system allocators T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 28, 2020
@TimDiekmann TimDiekmann mentioned this pull request Nov 28, 2020
Open
15 tasks
@Amanieu
Copy link
Member

Amanieu commented Dec 4, 2020

CI seems to be failing.

@TimDiekmann
Copy link
Member Author

@rustbot modify labels: +S-blocked

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 4, 2020
@bors
Copy link
Collaborator

bors commented Dec 30, 2020

☔ The latest upstream changes (presumably #80510) made this pull request unmergeable. Please resolve the merge conflicts.

DJMcNab added a commit to DJMcNab/retain_more that referenced this pull request Dec 31, 2020
@DJMcNab
Any allocator support comment
00a0a58 
rust-lang/rust#79500
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2021
@camelid camelid removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2021
@shlevy
Copy link
Contributor

shlevy commented May 12, 2021

@TimDiekmann Is there a workaround until this is merged to have owned str with a custom allocator?

@TimDiekmann
Copy link
Member Author

@TimDiekmann Is there a workaround until this is merged to have owned str with a custom allocator?

No, sorry. You can implement/use a custom String class with the same API as a drop-in replacement and provide a From implementation for std::String, but this is rather an unsatisfactory solution.

@lachlansneff
Copy link

Any chance this could happen soonish?

@matsadler matsadler mentioned this pull request Jun 11, 2022
Closed
@zachs18 zachs18 mentioned this pull request Sep 7, 2022
Draft
10 tasks
@zachs18
Copy link
Contributor

zachs18 commented Sep 7, 2022

@TimDiekmann I made an initial partial re-implementation of this PR (#101551) on the current master branch using the workaround(?) I mentioned in the blocking issue.
I can close that PR if you'd rather rebase this PR onto current master or something else.

@TimDiekmann
Copy link
Member Author

TimDiekmann commented Sep 7, 2022 •
edited
Loading

I currently don't have the time to rebase this branch, I'm sorry 🙁
I'll close this PR in favor of #101551

Feel free to base on this branch or whatever is the easiest for you 🙂

@TimDiekmann TimDiekmann closed this Sep 7, 2022
@zachs18 zachs18 mentioned this pull request Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
A-allocators Area: Custom and system allocators S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@TimDiekmann @Amanieu @bors @shlevy @lachlansneff @zachs18 @JohnCSimon @rust-highfive @camelid @rustbot